Repository navigation
0.1.2 (12/15): fix script preflight and menu path handling - #13
Merged
Merged
Conversation
trevoedwards
force-pushed
the
pr/0.1.2-12-script-fixes
branch
2 times, most recently
from
November 1, 2026 03:54
e89b8e9 to
1315af8
Compare
Match normal-layer window-server windows against checked AX windows and descendants, excluding icon and menu-bar backing chrome. Preserve hidden and other-Space candidates, stable inventories, and bounded fail-closed traversal. Keep Mail's unclassified offscreen windows refused rather than exempting potentially hidden documents. Strengthen the additions integration assertion and document the remaining limitation. Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
Require an explicit empty live window name and Screen Recording preflight for backing exemptions. Derive the primary menu-bar frame from Window Server, require the measured sharing/store/alpha values, and retain every other layer-zero window. Bind checked AX windows and descendants to their server IDs, refuse failed or duplicate mappings, and compare onscreen state on re-read. Add display-aware source regressions and document the rules. Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
… changes Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…idden windows keep it refused Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
macOS 27.2 apps' helper windows change size between sessions (TextEdit's was 64×64, then 500×500; Mail has 500×500 and 100×132 ones), so the exact-shape rule refused them. A document window takes its file's name, so an offscreen window whose title is present and empty, read with Screen Recording and with the measured backing traits, isn't one. Titled or unreadable offscreen windows and every onscreen window still match AX by window ID. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ning the run Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ls to send JSON-encoded arrays The 0.1.2 eval made 60 failing mac_menu calls with paths like '["File", "Save As…"]' (none in 0.1.1), after the description gained an array example on a string parameter. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Encode every-document and every-window selectors as absolute ordinals so Cocoa can resolve the host inventory query. Preserve complete-inventory and protected-path checks, reproduce the offscreen untitled TextEdit shape, and use a window count for ordinary Finder automation. Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
trevoedwards
force-pushed
the
pr/0.1.2-12-script-fixes
branch
from
November 1, 2026 03:54
1315af8 to
e0fd283
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 12 of the 0.1.2 stack. Depends on part 11; base:
pr/0.1.2-11-pause-hardening. Merge the preceding PR first. Existing topic commits and AI co-author trailers are preserved; already-merged CI fixes are carried through the stack.Real scripts exposed two document-gate problems: macOS 27 helper windows made AX/Window Server counts disagree, and the host's own every-document query used the wrong selector descriptor. The agent eval also exposed a menu-path wording regression. This fixes all three while retaining the document/path checks.
Source/probe regressions and live-script checks covered the selector and window rules. After these fixes the foreground Haiku evaluation passed 31/31; this PR's CI checks its stacked head.
PR prepared with Codex. Original implementation co-author trailers are retained.